fix: fix error when loading SequenceMeta as dict #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #310 +/- ##
==========================================
- Coverage 78.24% 78.15% -0.09%
==========================================
Files 15 15
Lines 671 673 +2
==========================================
+ Hits 525 526 +1
- Misses 146 147 +1 ☔ View full report in Codecov by Sentry. |
tlambert03
reviewed
Feb 2, 2024
tlambert03
reviewed
Feb 2, 2024
| @@ -49,21 +49,20 @@ def value(self) -> MDASequence: | |||
| split_channels=bool(split), | |||
| save_dir=widget_meta.get("save_dir", ""), | |||
| file_name=widget_meta.get("save_name", ""), | |||
| should_save=bool("save_dir" in widget_meta), | |||
| should_save="save_dir" in widget_meta, | |||
There was a problem hiding this comment.
did the linter remove this? or did you?
|
#311 was a more granular fix to the test. the underlying issue has to do with useq schema's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix
SequenceMeta/dicterror in tests not passing both locally and in in #309:FAILED tests/test_multid_widget.py::test_saving_mda[splitC-nT=0-nZ=0-nC=1] - AttributeError: 'dict' object has no attribute 'split_channels'note: new test added